Fix strict equality check if operand item type has custom __eq__ #14513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't complain about comparing lists, variable-legnth tuples or sets if one of the operands has an item type with a custom __eq__ method. Fix #14511.
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/dtypes/cast.py:792: error: Unused "type: ignore" comment
+ pandas/core/dtypes/cast.py:799: error: Unused "type: ignore" comment
+ pandas/core/arrays/arrow/array.py:330: error: Unused "type: ignore" comment
+ pandas/core/arrays/datetimes.py:2503: error: Unused "type: ignore" comment
+ pandas/core/arrays/datetimes.py:2513: error: Unused "type: ignore" comment
+ pandas/core/arrays/sparse/array.py:919: error: Unused "type: ignore" comment
+ pandas/io/json/_json.py:1135: error: Unused "type: ignore" comment
|
JukkaL
added a commit
that referenced
this pull request
Jan 24, 2023
Fixes regression introduced in #14513.
ilinum
pushed a commit
that referenced
this pull request
Jan 24, 2023
Fixes regression introduced in #14513.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't complain about comparing lists, variable-length tuples or sets if one of the operands has an item type with a custom
__eq__method.Fix #14511.