-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test with 32-bit Python #14634
Test with 32-bit Python #14634
Conversation
This comment has been minimized.
This comment has been minimized.
Yeah, we should probably continue testing on a 32-bit architecture. Maybe just running mypyc tests would be enough to catch most issues? Windows CI tends to be pretty slow. |
That or cross-compiling to x86 under Linux; whichever works! |
I'm not sure how easy this would be to set up in GitHub actions. We might need to use Docker, which may be too involved. Continuing to use 32-bit Windows may be our best bet, but without running the entire test suite. |
This comment has been minimized.
This comment has been minimized.
I rebased on top of @JukkaL 's 32-bit test case fixes in 563e29d There are some failures, but I think they are just from path changes
|
79ddeeb
to
8554dbb
Compare
This comment has been minimized.
This comment has been minimized.
75a4157
to
a1aaa87
Compare
Debian does build 32bit and there was a recent regression
@JukkaL I added 32-bit Linux testing (instead of MS Windows), updated the description, and marked this PR as ready for review |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Debian does build 32bit (on Linux), and there was a recent regression
This PR would have caught #14633 earlier
No change in total CI time (32 minutes) versus the baseline (33 minutes)
Confirmation that the new CI test catches the previous error is at https://github.com/python/mypy/actions/runs/4174055572/jobs/7227150570#step:7:44