Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate literal bool argument error messages #14693

Conversation

wesleywright
Copy link
Collaborator

Follow up on some of the recurring feedback from #14580 and #14657. There are many error messages similar to X must be True or False. in MyPy. This commit updates them all to:

  • remove the dangling period for consistency with other error messages
  • clarify that we need a True or False literal
  • use the literal-required error code for consistency with other literal errors

This should have no impact outside of error message formatting.

@wesleywright wesleywright marked this pull request as ready for review February 13, 2023 19:40
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these more consistent!

@JukkaL JukkaL merged commit 0b4ccae into python:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants