Allow iterable class objects to be unpacked (including enums) #14827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14782
Currently, mypy issues a false positive if you try to unpack an enum class:
This is because of a more general problem with class objects that have
__iter__
defined on their metaclass. Mypy issues a false positive on this code, whereFoo
is iterable by virtue of havingMeta
as its metaclass:This PR fixes the false positive with enums, and the more general false positive with iterable class objects.