Use asserts instead of casts where possible
#14860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
added a commit
to AlexWaygood/mypy
that referenced
this pull request
Mar 11, 2023
Split off from python#14860, since this one is a no-brainer
JelleZijlstra
pushed a commit
that referenced
this pull request
Mar 11, 2023
Split off from #14860, since this one is a no-brainer. `args[0]` has just been narrowed to be of type `StrExpr` in the lines immediately above, and `args` is the same as `call.args`.
JelleZijlstra
approved these changes
Mar 11, 2023
|
Moving this back into draft: looking at this again, I think you're right; we can fairly easily improve the signature of |
This comment has been minimized.
This comment has been minimized.
Here's a better solution for the |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many places in mypy's code where
casts are currently used unnecessarily. These can be replaced withasserts, which are much more type-safe, and more mypyc-friendly.