[dataclass_transform] fix frozen behavior for base classes with direct metaclasses #14878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14857. The initial implementation overlooked this statement in PEP 681:
As far as I can tell, this is a special case that only applies to classes that directly specify a
dataclass_transform
metaclass. This is import for projects like Pydantic, which requires clients to use a base class but still supports afrozen
parameter.Note that this allows mixed frozen and non-frozen behavior if the base class does have fields:
While this is probably surprising behavior, it seems to match the text of the PEP as well as the behavior of Pyright.