Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stubtest false positives with TypedDicts at runtime #14984

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Fix stubtest false positives with TypedDicts at runtime #14984

merged 2 commits into from
Apr 4, 2023

Conversation

AlexWaygood
Copy link
Member

Fixes #14983

hauntsaninja
hauntsaninja approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hauntsaninja hauntsaninja merged commit bf82b76 into python:master Apr 4, 2023
@AlexWaygood AlexWaygood deleted the stubtest-typeddict branch April 4, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
topic-stubtest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stubtest: Many false positives when the runtime has a TypedDict
3 participants
@AlexWaygood @sobolevn @hauntsaninja