Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pyupgrade on the sources #14985

Closed
wants to merge 3 commits into from
Closed

Run pyupgrade on the sources #14985

wants to merge 3 commits into from

Conversation

sobolevn
Copy link
Member

This PR introduces quite a lot of changes, please feel free to close if this creates unneeded churn.

docs/source/conf.py Outdated Show resolved Hide resolved
sobolevn and others added 2 commits March 30, 2023 23:02
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood
Copy link
Member

AlexWaygood commented Mar 30, 2023

Oh I thought the mypyc-segfaults-on-namedtuples-with-forward-refs issue had been fixed by #14401 (cc. @ichard26)

Edit: I guess this is a slightly different situation, since it specifically involves __future__ annotations rather than forward refs in general?

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@ichard26
Copy link
Collaborator

Edit: I guess this is a slightly different situation, since it specifically involves future annotations rather than forward refs in general?

Yeah, PR #14401 only fixes stringified forward references. Non-stringified forward references (thanks to from __future__ import annotations) are still liable to blowing up. I can take a look this weekend at fixing that.

@sobolevn
Copy link
Member Author

@ichard26 please ping me afterwards to merge this :)

@hauntsaninja hauntsaninja marked this pull request as draft April 26, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants