Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mypy_primer comment #15144

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Improve mypy_primer comment #15144

merged 2 commits into from
Apr 28, 2023

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Apr 26, 2023 •
edited
Loading

@hauntsaninja hauntsaninja mentioned this pull request Apr 26, 2023
Closed
@github-actions

This comment has been minimized.

Sign in to view
@srittau
Copy link
Contributor

srittau commented Apr 27, 2023

Maybe we should add a green checkmark to the message, similar to the one for approvals on GitHub?

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit 29cc561 into python:master Apr 28, 2023
@hauntsaninja hauntsaninja deleted the mypyprimercomm branch April 28, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"no effect" message confused me
3 participants
@hauntsaninja @srittau @ilevkivskyi