stubgen: Do not remove Generic from base classes #15316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider this python code:
```python
from typing import Generic, TypeVar
T = TypeVar("T")
class C(Generic[T]): ...
```
This is what stubgen produced before:
```python
from typing import TypeVar
T = TypeVar('T')
class C: ...
```
and this after:
```python
from typing import Generic, TypeVar
T = TypeVar('T')
class C(Generic[T]): ...
```
Note that stubgen handles generics correctly in --parse-only mode already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this python code:
This is what stubgen produced before:
and this after:
Note that stubgen handles generics correctly in --parse-only mode already.