Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on NamedTuple as attribute #15404

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

ilevkivskyi
Copy link
Member

Fixes #15380

Note I also update the NamedTuple fixture to be much closer to real definition in typing.pyi in typeshed.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@ilevkivskyi ilevkivskyi merged commit 3cedd27 into python:master Jun 9, 2023
@ilevkivskyi ilevkivskyi deleted the fix-nt-crash branch June 9, 2023 17:55
jhance pushed a commit that referenced this pull request Jun 12, 2023
Fixes #15380

Note I also update the `NamedTuple` fixture to be much closer to real
definition in `typing.pyi` in typeshed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting 'item' attribute as an instance created earlier leads to an internal error
2 participants