Special-case unions in polymorphic inference #16461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: discord.py (https://github.com/Rapptz/discord.py): typechecking got 1.08x slower (173.5s -> 186.8s)
(Performance measurements are based on a single noisy sample)
|
JukkaL
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
This looks a bit ad-hoc, but I can't propose a better way of solving the issue.
The use case that this supports seems sufficiently fundamental that it would be unfortunate not to support it. Empty mypy_primer output indicates that this is likely a net improvement. Looking for a more principled approach in the future would be nice, though.
|
@JukkaL Yeah. I was thinking about re-working union inference in general. But so far it seems to me whatever we do, we will need some kind of special-casing (at least for types like |
JukkaL
pushed a commit
that referenced
this pull request
Nov 22, 2023
Fixes #16451 This special-casing is unfortunate, but this is the best I came up so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16451
This special-casing is unfortunate, but this is the best I came up so far.