Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider TypeVarTuple to be invariant #16759

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Jan 7, 2024

The TypeVarTuple equality checks mentioned in PEP 646 assume TypeVarTuple to be invariant.
https://peps.python.org/pep-0646/#type-variable-tuple-equality

Fixes: #16739

Copy link
Contributor

github-actions bot commented Jan 7, 2024

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@hauntsaninja hauntsaninja merged commit 7a746c4 into python:master Jan 30, 2024
18 checks passed
@cdce8p cdce8p deleted the typeVarTuple-invariant branch January 30, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeVarTuple equality checks not implemented
2 participants