Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply TypeVar defaults to callables (PEP 696) #16842

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Jan 31, 2024

Implement type application for callables with TypeVar defaults.
Similar to previous PRs, support for TypeVarTuples is still TODO.

Ref: #14851

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

ibis (https://github.com/ibis-project/ibis)
- ibis/expr/operations/tests/test_generic.py:56: error: Type application has too few types (2 expected)  [misc]
- ibis/expr/operations/tests/test_generic.py:62: error: Type application has too few types (2 expected)  [misc]
- ibis/expr/operations/tests/test_generic.py:65: error: Type application has too few types (2 expected)  [misc]
- ibis/expr/operations/tests/test_generic.py:66: error: Type application has too few types (2 expected)  [misc]
- ibis/expr/operations/tests/test_generic.py:67: error: Type application has too few types (2 expected)  [misc]
- ibis/expr/operations/tests/test_generic.py:69: error: Type application has too few types (2 expected)  [misc]
- ibis/expr/operations/tests/test_generic.py:73: error: Type application has too few types (2 expected)  [misc]
- ibis/expr/operations/tests/test_generic.py:75: error: Type application has too few types (2 expected)  [misc]
- ibis/expr/operations/tests/test_generic.py:79: error: Type application has too few types (2 expected)  [misc]
- ibis/expr/operations/tests/test_generic.py:85: error: Type application has too few types (2 expected)  [misc]
- ibis/expr/operations/tests/test_generic.py:88: error: Type application has too few types (2 expected)  [misc]

@JelleZijlstra JelleZijlstra merged commit 55247c4 into python:master Jan 31, 2024
18 checks passed
@cdce8p cdce8p deleted the TypeVar-08-apply-callable branch January 31, 2024 16:10
@cdce8p cdce8p added the topic-pep-696 TypeVar defaults label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-pep-696 TypeVar defaults
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants