Expand TypeVarTuple default (PEP 696) #16851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
force-pushed
the
TypeVar-09-expand-TypeVarTuple
branch
from
7e08baf
to
3f69b90
Compare
JelleZijlstra
approved these changes
Feb 1, 2024
cdce8p
commented
Feb 1, 2024
Comment on lines
1542
to
+1544
| # WARNING: do not increase this number unless absolutely necessary, | ||
| # and you understand what you are doing. | ||
| ALLOWED_GET_PROPER_TYPES = 8 | ||
| ALLOWED_GET_PROPER_TYPES = 9 |
There was a problem hiding this comment.
@JelleZijlstra The test here just counts all get_proper_type calls inside expandtype. I believe the change still makes sense and is necessary to be able to compare the type inside Unpack. Furthermore, it's guarded by the isinstance check so the performance penalty should probably be minimal. Let me know what you think.
No other test case so far would reach that, only the new TypeVarTuple default ones.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to fix an error when expanding a TypeVarTuple default.
Ref: #14851