Improve error message for bound typevar in TypeAliasType #17053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #17038
When a type variable is bound to a class, it cannot be reused in a type alias. Previously in
TypeAliasType
, this error was reported as "not included in type_params". However in the following example, the error is misleading:On the master branch:
With this PR:
This is possible by storing the names of all the declared type_params, even those that are invalid, and checking if the offending type variables are in the list.