Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ParamSpec inference against TypeVarTuple #17431

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Fix ParamSpec inference against TypeVarTuple #17431

merged 2 commits into from
Jun 24, 2024

Conversation

ilevkivskyi
Copy link
Member

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

JukkaL
JukkaL approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixes! Looks good.

@ilevkivskyi ilevkivskyi merged commit 6c1d867 into python:master Jun 24, 2024
18 checks passed
@ilevkivskyi ilevkivskyi deleted the fix-tvt-vs-paramspec branch June 24, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot apply @asynccontextmanager to a function that uses TypeVarTuple TypeVarTuple causes mypy crash
2 participants
@ilevkivskyi @JukkaL