-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --install-types masking failure details #17485
Conversation
It seems that if the mypy cache dir wasn't created, this code would do an exit, preventing the actual errors from being printed. So I've removed the exit.
This comment has been minimized.
This comment has been minimized.
I should add that I've confirmed this works using https://github.com/tk-woven/mypy-install-types-mre I've installed my patch branch as a git source in pip, and it works on the mre. In contrast, when I installed the current mypy master ( I've been using the mypy from my patch branch as a daily driver and haven't noticed any other problems resulting from this change (although theoretically there could be some obscure edge case I just don't run into). |
As a note to myself: if this pr is accepted, or the issue is otherwise fixed, I can get rid of the workaround I added to this other project: https://github.com/databricks/databricks-sql-python/blob/main/.github/workflows/code-quality-checks.yml#L164 |
for more information, see https://pre-commit.ci
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
v1.14.1 is the current version, and python/mypy#17485 has the "upnext" label, so 1.15 should do
see python/mypy#17485 or python/mypy#10768 for more information
v1.14.1 is the current version, and python/mypy#17485 has the "upnext" label, so 1.15 should do
see python/mypy#17485 or python/mypy#10768 for more information
v1.14.1 is the current version, and python/mypy#17485 has the "upnext" label, so 1.15 should do Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
see python/mypy#17485 or python/mypy#10768 for more information Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
It seems that: if the mypy cache dir wasn't created, this code would do an exit, preventing the actual errors from being printed. So I've removed the exit. More information is available at the issue I claim this fixes.
Fixes #10768