-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually test a debug build #17822
base: master
Are you sure you want to change the base?
Actually test a debug build #17822
Conversation
This comment has been minimized.
This comment has been minimized.
Great, of course the tests fail! |
It looks like the errors coming from CPython and psutil?
I wonder if the tests would pass on a Python 3.9 debug build (or on an even more recent Python). |
The first error is from here: https://github.com/python/cpython/blob/63e54e6d4227e7cbdbb2a0ea69d11a904951f3a9/Objects/typeobject.c#L3129. This likely means we're calling I don't know what the psutil error is about. My first thought was that the release and debug ABIs were not yet compatible in 3.8, but Victor already made them compatible in 3.8 (python/cpython@f4e4703). Regardless, it's probably not worth trying to get these tests to pass on 3.8. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
47c7308
to
a82e3dc
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
I tried to reproduce the psutil error standalone, but haven't yet been able to. The PyErr_Occurred and LookupError are probably less mysterious. Putting this down for now, will pick it up later. |
eba5a38
to
be06e95
Compare
be06e95
to
323f657
Compare
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Taken from python/cpython@dcda92f I temporarly disabled some checks due to #17822
Fixes #17819