[mypyc] Optimize list.__add__, list.__iadd__, tuple.__add__ #18845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Mar 27, 2025
| @@ -21,6 +21,7 @@ Operators | |||
|
|
|||
| * ``tup[n]`` (integer index) | |||
| * ``tup[n:m]``, ``tup[n:]``, ``tup[:m]`` (slicing) | |||
| * ``tup1 + tup2`` | |||
There was a problem hiding this comment.
Is this only specialized for variable-length tuples? If yes, it's worth adding a note here, since fixed-length tuple concatenation could be quite slow otherwise.
There was a problem hiding this comment.
It should work for fixed-length tuple as well. Just the whole box / unbox dance which could possibly be optimized further at a later point.
| assert [1, 2] + [3, 4] == res | ||
| with assertRaises(TypeError, 'can only concatenate list (not "tuple") to list'): | ||
| assert [1, 2] + (3, 4) == res # type: ignore[operator] | ||
| assert in_place_add([3, 4]) == res |
There was a problem hiding this comment.
Test that the identity of the target object is preserved in +=?
JukkaL
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/3/c-api/sequence.html#c.PySequence_Concat
https://docs.python.org/3/c-api/sequence.html#c.PySequence_InPlaceConcat