Fix argparse for Python 3.14 #19020
Merged
Fix argparse for Python 3.14 #19020
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
This is the only remaining blocker for supporting Python 3.14 in typeshed (python/typeshed#13957). Is a release with this fix planned in the next few days? Otherwise I'd try to install mypy directly from GitHub in typeshed's CI. |
|
There are rumours of a release soon in #18739 But doesn't really hurt to install mypy directly from master... we've done it so many times in typeshed history |
mdickinson
added a commit
to mdickinson/simplefractions
that referenced
this pull request
May 17, 2025
This PR: - adds the missing `py.typed` marker file that indicates to consumers that the code has usable type hints - moves type checks to the test job of `on-commit` GitHub Actions workflow, instead of the style job. (Those type checks are Python-version dependent, and we want our type hints to be valid for all supported Python versions.) - fixes type hints to be Python 3.8-compatible on the `fraction_to_float.py` script Note: we're hitting a (known, fixed in main) issue with mypy and Python 3.14, so we skip the type check on Python 3.14 for now. xref: python/mypy#19020
This was referenced May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python/cpython#132323 added an optional
colorargument to ArgumentParser. As a side effect the help formatters are now called with two new keyword argumentsprefix_charsandcolor. Add**kwargsto the customAugmentedHelpFormatterand pass it through to the super class.