Skip to content

[mypyc] feat: support constant folding in convert_format_expr_to_str [1/1] #19970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[mypyc] feat: support constant folding in convert_format_expr_to_str [1/1] #19970

wants to merge 5 commits into from

Conversation

BobTheBuidler
Copy link
Contributor

This PR adds support for constant folding inside of convert_format_expr_to_str

JukkaL
JukkaL reviewed Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there existing run tests that cover this? If not, it would be good to add some. Maybe also add a simple irbuild test or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BobTheBuidler @JukkaL