[mypyc] feat: use exact_dict_rprimitive for star2 arg rtype [2/2] #20001
+35
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
BobTheBuidler
commented
Oct 3, 2025
| # immortal, but since this is expected to be very rare, and the immortality checks | ||
| # can be pretty expensive for lists, we treat lists as non-immortal. | ||
| list_rprimitive: Final = RPrimitive( | ||
| "builtins.list", is_unboxed=False, is_refcounted=True, may_be_immortal=False |
There was a problem hiding this comment.
should we also skip the immortality check on exact_dict and on dict?
|
We don't have anything in any of our IR tests that this impacts? Should that be the case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #19677 and implements exact_dict_rprimitive as the rtype for star2 args