Add NoReturn to mypy_extensions #2637
Conversation
|
BTW, #2635 waits for merging which speeds up tests significantly, that will help you get the green tick faster on pull requests like this one. |
|
Thanks for catching that! I went ahead and fixed all the whitespace errors in the file. |
|
Nice! How do you expect |
|
See: python/typeshed#811 Basically, it will be valid only in the return type position and will indicate that a function never returns. IIRC this is the last feature preventing |
|
You need to land this for https://travis-ci.org/python/typeshed/jobs/188986766 to pass. |
|
(Not quite -- the error was something else.) |
|
A relevant issue on By the way, if you are writing a runtime implementation, maybe it is worth adding a docstring, a nice |
This change is a step towards removing `runtests.py` (see #1673). The exclusion list in the flake8 configuration in `setup.cfg` has been updated to enable running the linter from the root of the project by simply invoking `flake8`. This enables it to leverage its own file discovery and its own multiprocessing queue without excessive subprocessing for linting every file. This gives a minor speed up in local test runs. Before: total time in lint: 130.914682 After: total time in lint: 20.379915 There's an additional speedup on Travis because linting is now only performed on Python 3.6. More importantly, this means flake8 is now running over all files unless explicitly excluded in `setup.cfg`. This will help avoiding unintentional omissions in the future (see comments on #2637). Note: running `flake8` as a single lazy subprocess in `runtests.py` doesn't sacrifice any parallelism because the linter has its own process pool. Minimal whitespace changes were required to `mypy_extensions.py` but in return flake8 will check it now exactly like it checks the rest of the `mypy/*` codebase. Those are also done on #2637 but that hasn't landed yet. Finally, flake8-bugbear and flake8-pyi were added to test requirements to make the linter configuration consistent with typeshed. I hope the additional checks will speed up future pull requests by automating bigger parts of the code review. The pyi plugin enables forward reference support when linting .pyi files. That means it's now possible to run `flake8` inside the typeshed submodule or on arbitrary .pyi files during development (which your editor could do for you), for example on fixtures. See discussion on #2629 on checks that are disabled and why.
|
So no |
|
Because it's too late to make that work in 3.6.0 or 3.5.3, plus it's hard
to search for.
…--Guido (mobile)
On Jan 7, 2017 10:42, "Elazar Gershuni" ***@***.***> wrote:
So no Union[()]?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2637 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACwrMp0-_G1_rM-IyQQqo_cCL90JeixNks5rP9yTgaJpZM4LbAVi>
.
|
Allow specifying that functions doesn't return in non-stub files.