Fix remaining testcheck tests for fast parser #2730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddfisher
force-pushed
the
fastparser-tests-4
branch
from
c3b20fd to
4204807
Compare
ddfisher
force-pushed
the
fastparser-tests-4
branch
from
4204807 to
eb62351
Compare
|
Rebased now that #2722 has landed. |
gvanrossum
reviewed
Jan 23, 2017
| @@ -381,15 +381,17 @@ main:4: error: Argument 2 to "f" has incompatible type *List[A]; expected "B" | |||
| main:5: error: Argument 3 to "f" has incompatible type *List[A]; expected "B" | |||
| main:6: error: Argument 1 to "f" has incompatible type *"Tuple[A, A, B]"; expected "B" | |||
|
|
|||
| [case testVarArgsAfterKeywordArgInCall1] | |||
| [case testVarArgsAfterKeywordArgInCall1-skip] | |||
| # see: mypy issue #2729 | |||
There was a problem hiding this comment.
I'm confused, that issue claims to be about Python 2, but this test (or the next) is not about Python 2 IIUC. What am I missing?
There was a problem hiding this comment.
See comments on issue. I was wrong about it being a Python 2-specific problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2722.