Do not support metaclasses not inheriting from type #2820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elazarg
changed the title
ilevkivskyi
reviewed
Feb 7, 2017
|
|
||
| reveal_type(A.x) # E: Revealed type is 'builtins.int' | ||
| A.x # E: "A" has no attribute "x" |
There was a problem hiding this comment.
I would add a test that checks that "indirect" inheritance works, like:
class M1(type):
x = 0
class M2(M1): pass
class C(metaclass=M2):
pass
reveal_type(C.x) # E: Revealed type is 'builtins.int'
Otherwise LGTM.
|
Looks good -- but there's now a merge conflict. |
|
Fixed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2818.
ABCMeta requires special treatment.
Related: #2475