Fix last character cut in html-report if file does not end with newline #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a file did not end with a newline, html-report would not output it.
|
The canonical way to solve this kind of thing is probably |
gvanrossum
reviewed
May 26, 2017
mypy/report.py
Outdated
| etree.SubElement(root, 'line', | ||
| number=str(lineno), | ||
| precision=stats.precision_names[status], | ||
| content=line_text) | ||
| content=line_text.strip('\n')) |
There was a problem hiding this comment.
Well, it should still be the same, since we know we are always processing one line. But rstrip() is probably better stylistically.
Originally, I was worried about removing legitimate newlines in the code. But they will be escaped and therefore won't be removed.
gvanrossum
approved these changes
May 26, 2017
carljm
added a commit
to carljm/mypy
that referenced
this pull request
May 30, 2017
* master: (23 commits) Make return type of open() more precise (python#3477) Add test cases that delete a file during incremental checking (python#3461) Parse each format-string component separately (python#3390) Don't warn about returning Any if it is a proper subtype of the return type (python#3473) Add __setattr__ support (python#3451) Remove bundled lib-typing (python#3337) Move version of extensions to post-release (python#3348) Fix None slice bounds with strict-optional (python#3445) Allow NewType subclassing NewType. (python#3465) Add console scripts (python#3074) Fix 'variance' label. Change label for variance section to just 'variance' (python#3429) Better error message for invalid package names passed to mypy (python#3447) Fix last character cut in html-report if file does not end with newline (python#3466) Print pytest output as it happens (python#3463) Add mypy roadmap (python#3460) Add flag to avoid interpreting arguments with a default of None as Optional (python#3248) Add type checking plugin support for functions (python#3299) Mismatch of inferred type and return type note (python#3428) Sync typeshed (python#3449) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file did not end with a newline, html-report would not output it.
I couldn't find any tests for html report. Maybe it's worth having some.