Fix crash in --quick mode when aliases are re-exported #3740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow it's beautiful! (Especially the test. Amazing that you could repro that from those tracebacks.) |
Thanks! This is why I became a scientist -- I like to investigate, but it turns out there are interesting cases for investigations not only in science :-) |
gvanrossum
pushed a commit
to gvanrossum/mypy
that referenced
this pull request
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3355
This happens since dependencies in
--quickmode are not rechecked, therefore we need to put something in place of the outdated values.In general, I could imagine there are similar problems with outdated values in
--quickmode, so that it is better to move towards fine grained incremental, that actually rechecks dependencies.