Make tuple generic in most stubs #3767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Jul 26, 2017
| @@ -11,7 +11,7 @@ class int: pass | |||
| class str: pass | |||
| class dict: pass | |||
There was a problem hiding this comment.
Maybe you could also fix dict and set (on next line)? There are few of them.
There was a problem hiding this comment.
The idea is that if you also fix few dicts and sets, then we could turn on the asserts that are now commented out.
| class function: pass | ||
| class ellipsis: pass | ||
| class list: pass |
There was a problem hiding this comment.
It looks like there is still one more tuple not fixed in isinstancelist.pyi.
ilevkivskyi
approved these changes
Jul 26, 2017
|
Can you please measure how much slower this made the tests?
…On Jul 26, 2017 3:03 PM, "Ivan Levkivskyi" ***@***.***> wrote:
Merged #3767 <#3767>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3767 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ACwrMtHSI54dp01iYwdepyCfsQFQM8Nyks5sR7eugaJpZM4Ojafa>
.
|
Before: 3m7s The full test runs two more seconds, i.e. less than 1% of total time. |
|
OK, that's fine then. In general the tests have become slower over time, in part because mypy itself became slower; but IIRC we had a recent test speedup, and this slowdown is negligible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @ilevkivskyi suggestion, making tuples generic in stubs to reduce incompatibility between stubs and production.
This is a carve-out from #3129.