Move testtransform to pytest #3788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elazarg
commented
Aug 1, 2017
| c = [] # type: List[DataDrivenTestCase] | ||
| for f in self.transform_files: | ||
| for f in cls.transform_files: | ||
| c += parse_test_cases(os.path.join(test_data_prefix, f), | ||
| test_transform, |
There was a problem hiding this comment.
The argument test_transform, which corresponds to the parameter perform, is not used in pytests. The parameter is propagated to DataDrivenTestCase which uses it in the method run(). This method is not called; maybe we should add assert False there.
This was referenced Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another item from #1673, following #3780
I have checked that some tests fail by changing
testGlobalVariablefrom 'semanal-basic.test' and running(
testsemanalis not a pytest yet)