-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Running on Python 3.3 is no longer supported #4152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -3,6 +3,12 @@ Revision history | |||
|
|||
List of major changes: | |||
|
|||
- Upcoming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this -- it makes it easier to collect everything relevant to the next release in one place (rather than having to scour the logs a day before the release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do something similar for Pillow: https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst
docs/source/revision_history.rst
Outdated
- Upcoming | ||
* Publish ``mypy`` version 0.550 on PyPI. | ||
|
||
* We soon intend to drop support for Python 3.3, which has reached end-of-life. Please comment on `#4036 <https://github.com/python/mypy/issues/4036>`_ if this is an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should just be "Running mypy now requires Python 3.4 or higher." Perhaps also add "However Python 3.2 and 3.3 are still valid for the target of the analysis (i.e. the --python-version
flag)."
We already announced we would drop 3.3 support for running mypy in the blog post for 0.530 -- we just never followed through. FWIW the text there was:
Note that future mypy versions will still support checking older Python versions — they just won’t run on 3.3 or earlier. It’s easy to have multiple Python versions installed, so this won’t prevent anyone from running mypy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
docs/source/revision_history.rst
Outdated
- Upcoming | ||
* Publish ``mypy`` version 0.550 on PyPI. | ||
|
||
* Running mypy now requires Python 3.4 or higher. However Python 3.2 and 3.3 are still valid for the target of the analysis (i.e. the ``--python-version`` flag). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you break this long line? We don't like lines >= 80 characters in our docs; it makes reading on small screens or in side-by-side diffs cumbersome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also to my embarrassment we actually don't support --python-version 3.2
. You get
mypy: error: argument --python-version: Python 3.2 is not supported (must be 3.3 or higher)
However using 3.3 as a target is still supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is OK -- are you interested in also making the changes to .travis.yml and setup.py? In the same PR or a different one?
.travis.yml and setup.py updated here, along with some other documentation files. I expect there's some more code changes possible, but I think they can be in another PR. |
Great! Thanks for finding those other occurrences. The setup.py one was particularly embarrassing -- it would allow installing with 3.2 but then could not type-check 3.2. :-) |
For #4036.