Skip to content

Running on Python 3.3 is no longer supported #4152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2017
Merged

Running on Python 3.3 is no longer supported #4152

merged 4 commits into from
Oct 24, 2017

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 23, 2017

For #4036.

@@ -3,6 +3,12 @@ Revision history

List of major changes:

- Upcoming
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this -- it makes it easier to collect everything relevant to the next release in one place (rather than having to scour the logs a day before the release).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Upcoming
* Publish ``mypy`` version 0.550 on PyPI.

* We soon intend to drop support for Python 3.3, which has reached end-of-life. Please comment on `#4036 <https://github.com/python/mypy/issues/4036>`_ if this is an issue.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be "Running mypy now requires Python 3.4 or higher." Perhaps also add "However Python 3.2 and 3.3 are still valid for the target of the analysis (i.e. the --python-version flag)."

We already announced we would drop 3.3 support for running mypy in the blog post for 0.530 -- we just never followed through. FWIW the text there was:

Note that future mypy versions will still support checking older Python versions — they just won’t run on 3.3 or earlier. It’s easy to have multiple Python versions installed, so this won’t prevent anyone from running mypy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@hugovk hugovk changed the title Notify intention to drop support for 3.3 in an upcoming release Notify running on Python 3.3 is no longer supported Oct 24, 2017
@gvanrossum gvanrossum changed the title Notify running on Python 3.3 is no longer supported Running on Python 3.3 is no longer supported Oct 24, 2017
- Upcoming
* Publish ``mypy`` version 0.550 on PyPI.

* Running mypy now requires Python 3.4 or higher. However Python 3.2 and 3.3 are still valid for the target of the analysis (i.e. the ``--python-version`` flag).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you break this long line? We don't like lines >= 80 characters in our docs; it makes reading on small screens or in side-by-side diffs cumbersome.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also to my embarrassment we actually don't support --python-version 3.2. You get

mypy: error: argument --python-version: Python 3.2 is not supported (must be 3.3 or higher)

However using 3.3 as a target is still supported.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Updated!

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK -- are you interested in also making the changes to .travis.yml and setup.py? In the same PR or a different one?

@hugovk
Copy link
Member Author

hugovk commented Oct 24, 2017

.travis.yml and setup.py updated here, along with some other documentation files. I expect there's some more code changes possible, but I think they can be in another PR.

@gvanrossum gvanrossum merged commit 272d0c4 into python:master Oct 24, 2017
@gvanrossum
Copy link
Member

Great! Thanks for finding those other occurrences. The setup.py one was particularly embarrassing -- it would allow installing with 3.2 but then could not type-check 3.2. :-)

@hugovk hugovk deleted the patch-1 branch October 25, 2017 05:49
JukkaL pushed a commit that referenced this pull request Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants