Skip to content

Add a py.typed marker, per PEP 561 #4255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Nov 15, 2017

(Might want to wait merging this until PEP 561 is accepted.)

@gvanrossum gvanrossum closed this Jan 18, 2018
@gvanrossum gvanrossum deleted the pep561 branch January 18, 2018 22:50
@ilevkivskyi
Copy link
Member

Does this mean that PEP 561 will not go into 3.7?

@gvanrossum gvanrossum restored the pep561 branch January 19, 2018 01:25
@gvanrossum
Copy link
Member Author

Must have been a side-effect of prematurely cleaning out the branch.

FWIW I don't believe that there is any effect of PEP 561 on CPython, so I don't consider this urgent.

IIUC @ethanhs is still working on his implementation -- I'd like to play around with that before finalizing acceptance of his PEP (I believe he revised the PEP at least once as a result of something he encountered during implementation).

@gvanrossum gvanrossum reopened this Jan 19, 2018
@emmatyping
Copy link
Member

FWIW I don't believe that there is any effect of PEP 561 on CPython, so I don't consider this urgent.

Agreed, it doesn't need to be accepted before 3.7 lands.

IIUC @ethanhs is still working on his implementation -- I'd like to play around with that before finalizing acceptance of his PEP (I believe he revised the PEP at least once as a result of something he encountered during implementation).

Yes I am afraid I haven't had much time in the last month to work on it (or much of anything), but I hope to get back to it more this weekend.

@emmatyping
Copy link
Member

emmatyping commented Apr 9, 2018

Now that #4693 is merged I believe this can be merged too? (I will go ahead and fix the merge conflict). This should wait for the PEP to be accepted.

@gvanrossum gvanrossum closed this Apr 9, 2018
@gvanrossum gvanrossum deleted the pep561 branch April 9, 2018 21:46
@gvanrossum
Copy link
Member Author

Whoops pilot error. Will fix.

@gvanrossum
Copy link
Member Author

Actually I was very thorough in my misguided scrubbing of this branch. @ethanhs do you still have a copy?

gvanrossum pushed a commit to gvanrossum/mypy that referenced this pull request Apr 9, 2018
@emmatyping
Copy link
Member

emmatyping commented Apr 9, 2018

No I don't think so, I fixed the merge conflict online, so I don't have my own copy. Ah I see you fixed it.

@gvanrossum
Copy link
Member Author

OK, new one is in $4879. Is there a reason not to merge this in 0.590?

@emmatyping
Copy link
Member

I don't think so, no.

@gvanrossum
Copy link
Member Author

Hm, then why did you say previously "This should wait for the PEP to be accepted"? (IIUC you even edited your comment to strike through "I believe this can be merged too?" and add that.)

@emmatyping
Copy link
Member

You had said it should wait for the PEP to be accepted in the original comment. I have no reason to wait, so it's up to you. Apologies for the confusion.

gvanrossum added a commit that referenced this pull request Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants