-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add a py.typed marker, per PEP 561 #4255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does this mean that PEP 561 will not go into 3.7? |
Must have been a side-effect of prematurely cleaning out the branch. FWIW I don't believe that there is any effect of PEP 561 on CPython, so I don't consider this urgent. IIUC @ethanhs is still working on his implementation -- I'd like to play around with that before finalizing acceptance of his PEP (I believe he revised the PEP at least once as a result of something he encountered during implementation). |
Agreed, it doesn't need to be accepted before 3.7 lands.
Yes I am afraid I haven't had much time in the last month to work on it (or much of anything), but I hope to get back to it more this weekend. |
Now that #4693 is merged |
Whoops pilot error. Will fix. |
Actually I was very thorough in my misguided scrubbing of this branch. @ethanhs do you still have a copy? |
|
OK, new one is in $4879. Is there a reason not to merge this in 0.590? |
I don't think so, no. |
Hm, then why did you say previously "This should wait for the PEP to be accepted"? (IIUC you even edited your comment to strike through "I believe this can be merged too?" and add that.) |
You had said it should wait for the PEP to be accepted in the original comment. I have no reason to wait, so it's up to you. Apologies for the confusion. |
(Might want to wait merging this until PEP 561 is accepted.)