Don't have newly added files trigger a coarse-grained rebuild in fine-grained cache mode #4669
Conversation
There was a problem hiding this comment.
This looks like a reasonable way to move forward with this, though we may want to reconsider the approach in the future. Looks good otherwise, but I'd like to see more test coverage around this, since this use case is likely not hit very often. Feel free to merge after you've addressed my comments.
| @@ -971,3 +971,56 @@ x = Foo() | |||
| == | |||
| == | |||
| main:2: error: Too few arguments for "foo" of "Foo" | |||
|
|
|||
| [case testAddModuleAfterCache1] | |||
There was a problem hiding this comment.
Would it make sense to use the -skip-nocache suffix for some of these test cases?
There was a problem hiding this comment.
I don't see any need to. The main thing under test is cache behavior but they are still tests of module adding, which is subtle and could potentially find regressions in non-cache mode.
| a.py:2: error: Too many arguments for "foo" | ||
| == | ||
|
|
||
| [case testAddModuleAfterCache3] |
There was a problem hiding this comment.
I'd prefer to have more tests around this. For example, test that errors are correctly generated in all the new modules and existing modified modules, and make sure that we can correctly bind references to things defined in all three classes of modules:
- Cached but unmodified
- Cached and modified
- New modules
* master: New files shouldn't trigger a coarse-grained rebuild in fg cache mode (python#4669) Bump version to 0.580-dev Update revision history for 0.570 (python#4662) Fine-grained: Fix crashes when refreshing synthetic types (python#4667) Fine-grained: Support NewType and reset subtype caches (python#4656) Fine-grained: Detect changes in additional TypeInfo attributes (python#4659) Fine-grained: Apply semantic analyzer patch callbacks (python#4658) Optimize fine-grained update by using Graph as the cache (python#4622) Cleanup check_reverse_op_method (python#4017) Fine-grained: Fix AST merge issues (python#4652) Optionally check that we don't have duplicate nodes after AST merge (python#4647)
No description provided.