Skip to content

Refactoring: merge MypyDataCase into DataDrivenTestCase #5013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2018
Merged

Refactoring: merge MypyDataCase into DataDrivenTestCase #5013

merged 1 commit into from
May 14, 2018

Conversation

elazarg
Copy link
Contributor

@elazarg elazarg commented May 7, 2018 •
edited
Loading

Cleanup. The distinction between MypyDataCase and DataDrivenTestCase was only needed during the transition from myunit.

Most of the changes are nothing more than moving code around.

Additional changes:

  • rename MypyDataSuite to DataSuiteCollector which seems more appropriate
  • remove scripts/myunit.py (because why not)
  • remove unused DataSuite.filter

(Loosely related to #1673)

@elazarg elazarg force-pushed the unify-testclasses branch from c14d9ea to 852fe00 Compare May 7, 2018 23:10
msullivan
msullivan approved these changes May 14, 2018
View reviewed changes
Copy link
Collaborator

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Happy to see these merged, since I never totally understood what the division was supposed to be anyways ;)

@msullivan msullivan merged commit 89a8e67 into python:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elazarg @msullivan