-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for PyCharm test debugging, and add tox environment setup #5189
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ed5616b
add PyCharm debugging support
gaborbernat 2bebcac
make sure tests pass running from within PyCharm
gaborbernat 8ccac35
add tox configuration, and expose test runner via that
gaborbernat ffc6436
Avoid having a space between requirement files in tox config as that …
gaborbernat c3d2c28
Avoid redundant local variable for PyCharm identification
gaborbernat ea29148
Package suite moved to self-check
gaborbernat f3d718d
For type tox environment use self-check package instead of the test file
gaborbernat e5567f4
restore pytest.ini parallel mode
gaborbernat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
[tox] | ||
minversion = 2.9.1 | ||
skip_missing_interpreters = true | ||
envlist = py34, | ||
py35, | ||
py36, | ||
py37, | ||
lint, | ||
type, | ||
docs | ||
|
||
[testenv] | ||
description = run the test driver with {basepython} | ||
deps = -rtest-requirements.txt | ||
commands = python runtests.py -x lint -x self-check {posargs} | ||
|
||
[testenv:lint] | ||
description = check the code style | ||
basepython = python3.6 | ||
commands = python runtests.py lint {posargs} | ||
|
||
[testenv:type] | ||
description = type check ourselves | ||
basepython = python3.6 | ||
commands = python runtests.py self-check -p '-n0' -p '-v' | ||
|
||
[testenv:docs] | ||
description = invoke sphinx-build to build the HTML docs | ||
basepython = python3.6 | ||
deps = -rdocs/requirements-docs.txt | ||
commands = sphinx-build -d "{toxworkdir}/docs_doctree" docs/source "{toxworkdir}/docs_out" --color -W -bhtml {posargs} | ||
|
||
[testenv:dev] | ||
description = generate a DEV environment, that has all project libraries | ||
usedevelop = True | ||
basepython = python3.6 | ||
deps = -rtest-requirements.txt | ||
-rdocs/requirements-docs.txt | ||
commands = python -m pip list --format=columns | ||
python -c 'import sys; print(sys.executable)' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks quite fragile (what if the debugger output format changes?). Is it possible to configure the debugger to just not print these lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please don't rebase your PR, merge when needed, otherwise it is hard to follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need to follow up then and amend it; I haven't found a way to disable it sadly 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.