Force-enable strict optional only when checking for unsafe overlaps #5252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a note, these tests will currently fail. They should start passing once python/typeshed#2261 is merged and I do the typeshed sync dance. |
Resolves python#5246 Previously, we force-enabled strict optional checks when performing all overload definition checks. This ended up causing mypy to miss some errors in definitions when `--no-strict-optional` mode is enabled. This commit will now force-enable strict optional only when checking if overloads are unsafely overlapping: we use the existing mode when checking if one variant completely eclipses another or when checking the implementation.
Michael0x2a
force-pushed
the
tighten-strict-optional-mode-in-overload-defn-checks
branch
from
9c7687b to
5cbfa5c
Compare
ilevkivskyi
approved these changes
Jun 21, 2018
There was a problem hiding this comment.
LGTM!
The extra bogus errors still appear after we detect unsafety, but they are unrelated to overloads but to failed type variable inference with the first match. A potential option (in a separate PR, low priority) would be to somehow mark unsafe (or otherwise broken) overload definitions and return Any(TypeOfAny.from_error) at the call sites to limit bogus errors.
Michael0x2a
deleted the
tighten-strict-optional-mode-in-overload-defn-checks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5246
Previously, we force-enabled strict optional checks when performing all overload definition checks. This ended up causing mypy to miss some errors in definitions when
--no-strict-optionalmode is enabled.This commit will now force-enable strict optional only when checking if overloads are unsafely overlapping: we use the existing mode when checking if one variant completely eclipses another or when checking the implementation.