Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaces refactor part 2 #5690

Merged
merged 8 commits into from
Sep 29, 2018
Merged

Conversation

gvanrossum
Copy link
Member

This is more mindless refactoring.

  • Inline type_check_only() -- there was only one call and all it did was rearrange the arguments
  • Drop bin_dir argument -- nothing uses it
  • Fix some imports in test/testcheck.py, dmypy_server.py and server/update.py
  • Two other small refactors in test/testcheck.py
  • Fix some mis-indented parameters

@gvanrossum gvanrossum merged commit ecdd4b2 into python:master Sep 29, 2018
@gvanrossum gvanrossum deleted the namespaces-refactor-2 branch September 29, 2018 21:08
TV4Fun pushed a commit to TV4Fun/mypy that referenced this pull request Oct 4, 2018
* Get rid of trivial type_check_only() function

* Remove bin_dir -- it's no longer used

* Fix wrong import in testcheck.py

* Fix indent of compute_search_paths() args

* Minor cleanup in mypy/test/testcheck.py

* Cleanups in mypy/dmypy_server.py and mypy/server/

* Fix lint

* Fix lint fix
97littleleaf11 added a commit that referenced this pull request Aug 14, 2022
`script_path` was entirely useless since `bin_dir` had been dropped long time
ago by #5690. This PR also makes arguments of mypy.main keyword-only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants