-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Provide an "API" for invoking the daemon #5972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,8 +15,9 @@ | |
import subprocess | ||
import sys | ||
import time | ||
import traceback | ||
|
||
from typing import Any, Callable, Dict, Mapping, Optional, Tuple | ||
from typing import Any, Callable, Dict, Mapping, Optional, Tuple, List | ||
|
||
from mypy.dmypy_util import STATUS_FILE, receive | ||
from mypy.ipc import IPCClient, IPCException | ||
|
@@ -114,16 +115,21 @@ class BadStatus(Exception): | |
pass | ||
|
||
|
||
def main() -> None: | ||
def main(argv: List[str]) -> None: | ||
"""The code is top-down.""" | ||
args = parser.parse_args() | ||
args = parser.parse_args(argv) | ||
if not args.action: | ||
parser.print_usage() | ||
else: | ||
try: | ||
args.action(args) | ||
except BadStatus as err: | ||
sys.exit(err.args[0]) | ||
except Exception: | ||
# We do this explicitly to avoid exceptions percolating up | ||
# through mypy.api invocations | ||
traceback.print_exc() | ||
sys.exit(2) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like this choice, I think there are still some situations where 1 can be returned on a traceback in the server, but I will fix those separately later. |
||
|
||
|
||
ActionFunction = Callable[[argparse.Namespace], None] | ||
|
@@ -483,4 +489,4 @@ def is_running() -> bool: | |
# Run main(). | ||
|
||
if __name__ == '__main__': | ||
main() | ||
main(sys.argv[1:]) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC this doesn't support incremental flushing of errors (maybe we will do this at some point), but it is the same for normal runs, so probably OK. Maybe add a comment about this.