Implement overlapped I/O and timeouts on server side Windows IPC #6148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
reviewed
Jan 5, 2019
emmatyping
added a commit
to emmatyping/typeshed
that referenced
this pull request
Jan 5, 2019
This was referenced Jan 5, 2019
Closed
srittau
pushed a commit
to python/typeshed
that referenced
this pull request
Jan 7, 2019
Merged
emmatyping
added a commit
that referenced
this pull request
Jan 7, 2019
With updates to _winapi for #6148.
gvanrossum
reviewed
Jan 7, 2019
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
hauntsaninja
pushed a commit
that referenced
this pull request
Nov 1, 2022
As per the TODO comments, this PR removes some unnecessary `assert`s in `mypy/ipc.py`. When these `assert`s were added in #6148, typeshed wasn't able to use `Literal` types yet. However, nowadays, typeshed has precise `Literal` overloads for `_winapi.WriteFile` and `_winapi.ConnectNamedType`, meaning mypy is able to precisely infer the return type of these function calls without the need for the `assert`s in `mypy/ipc.py`: https://github.com/python/typeshed/blob/main/stdlib/_winapi.pyi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
b''as anEOFsignalNote that sadly this will fail self type checking (edit: on Windows) since their signatures in typeshed are for the non-overlapped versions (I will be making a PR to typeshed soon PR here: python/typeshed#2723).(The PR is merged and synced). The PR ended up relaxing the return types, so I added some asserts for greater type safety.A lot of the overlapped I/O is based on the docs and https://github.com/python/cpython/blob/master/Lib/multiprocessing/connection.py. The main difference is the timeouts and I used
WaitForSingleObject, since that seems sufficient for our purposes.Fixes #5962