Skip to content

Move message constants to mypy.message_registry #6194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2019
Merged

Move message constants to mypy.message_registry #6194

merged 1 commit into from
Jan 15, 2019

Conversation

chadrik
Copy link
Contributor

@chadrik chadrik commented Jan 15, 2019

This is the next step toward message filtering (#2417), and a precursor to PR #6152.

By moving constants to their own module we can easily inspect them to get both their name and value, for use within a message filtering system.

@chadrik
Move message constants to mypy.message_registry
c0a8c6e 
This is in preparation for message filtering
JukkaL
JukkaL approved these changes Jan 15, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! This will allow a cleaner implementation of message ids.

@JukkaL JukkaL merged commit cdfca4f into python:master Jan 15, 2019
@chadrik chadrik mentioned this pull request Feb 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chadrik @JukkaL