Use variable name to determined NamedTuple class name #6698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As we discussed offline, it may be better to do this as part of a larger clean-up proposed in #6422, unless this is urgent. |
|
This issue got reported again at Dropbox and since #6422 seems moribund, I've rebased this. I don't remember what the objections we discussed were. @ilevkivskyi, what are your thoughts about merging this now? |
|
I didn't do a full review, but I think that this is a reasonable incremental improvement. I agree that it would be even better to fix #6422, but it could take a long time before it happens, unfortunately. |
|
@msullivan Yes, go ahead, it is unlikely I will ever work on #6422. |
msullivan
force-pushed
the
namedtuple
branch
from
329f91e to
1c08006
Compare
This lets us avoid inserting line numbers into the name when the variable name and argument to NamedTuple disagree. This is good, because the line numbers are ugly and when combined with bug #6548 causes problems when a namedtuple is reexported.
|
Apparently after rebasing this I then forgot about it, so I'm rebasing again and am actually going to land it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us avoid inserting line numbers into the name when the
variable name and argument to NamedTuple disagree. This is good,
because the line numbers are ugly and when combined with bug #6548
causes problems when a namedtuple is reexported.