Skip to content

Fix mypyc build #6743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2019
Merged

Fix mypyc build #6743

merged 1 commit into from
Apr 29, 2019

Conversation

msullivan
Copy link
Collaborator

Which doesn't support **kwargs

@msullivan
Fix mypyc
5fe085e 
Which doesn't support **kwargs
@msullivan msullivan requested a review from JukkaL April 29, 2019 21:47
@msullivan
Copy link
Collaborator Author

And of course, since not even I can remember to not use features mypyc doesn't support, I need to add mypyc to our CI: #6170

ilevkivskyi
ilevkivskyi approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@msullivan msullivan merged commit d387906 into master Apr 29, 2019
@msullivan msullivan deleted the fix-mypyc branch April 29, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@JukkaL JukkaL Awaiting requested review from JukkaL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msullivan @ilevkivskyi