Support '# mypy: ' comments for inline configuration #6839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
force-pushed
the
per-module-flags-actually
branch
from
a6e5f14
to
9b15343
Compare
msullivan
force-pushed
the
per-module-flags-actually
branch
from
9b15343
to
c85d6d4
Compare
Implements line configuration using '# mypy: ' comments, following the blueprint I proposed in #2938. It currently finds them just using a regex which means it is possible to pick up a directive spuriously in a string literal or something but honestly I am just not worried about that in practice. Examples of what it looks like in the tests. Fixes #2938. Thoughts?
msullivan
force-pushed
the
per-module-flags-actually
branch
from
340834d
to
096ec21
Compare
|
General idea looks solid to me. Probably worth adding some tests for invalid I didn't do a proper review (yet). |
gvanrossum
reviewed
May 19, 2019
ilevkivskyi
reviewed
May 19, 2019
| [case testInlineError1] | ||
| # mypy: invalid-whatever | ||
| [out] | ||
| main: error: Unrecognized option: invalid_whatever = True |
There was a problem hiding this comment.
I would add more tests for the cases when user did something wrong:
- what if there is extra spaces around
=? - what if
;used as a separator? - what if a user forgot to quote a flag value that has commas?
etc.
msullivan
changed the title
|
I am happy with how this all looks now. Currently we produce an error on a skip-file directive. We could make it actually skip in a follow-up PR. |
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
Implements line configuration using '# mypy: ' comments, following the the discussion in python#2938. It currently finds them in a pretty primitive manner which means it is possible to pick up a directive spuriously in a string literal or something but honestly I am just not worried about that in practice. Documentation to come in a follow-up PR. Fixes python#2938.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements line configuration using '# mypy: ' comments, following the
blueprint I proposed in #2938.
It currently finds them just using a regex which means it is possible to pick
up a directive spuriously in a string literal or something but honestly I am
just not worried about that in practice.
Examples of what it looks like in the tests.
Still needs documentation.
Fixes #2938.
Thoughts?
(This is stacked on #6838 so can't be merged yet)