-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Remove Undefined from stubs #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cool, thanks for the PR! A lot of "Python evaluation" tests (that use full stubs) are failing -- it could be an problem with By the way, are you working on other parts of #680? If you are not working on test cases, I'm probably going to start updating them to not use |
Huh, strange. It seems as though the
I haven't worked on anything else for #680, so I'm quite happy for you to continue working on it - I would like to get back to #638 at some point :) |
I removed most uses of |
73f47f1
to
40d8e99
Compare
These commits close #680 and include the latest version of typing.py from ambv/typehinting. |
Great, almost there! I did a quick pass and found a few issues: In
In
I found a few other instances where Also, the best replacement for an |
40d8e99
to
e64a844
Compare
e64a844
to
fd0d1af
Compare
I fixed the two cases you mentioned above and went through all of the functions which were modified, ensuring that |
Part of #680