New analyser: fix crashes when plugins encounter a placeholder node #7132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Jul 2, 2019
mypy/plugins/attrs.py
Outdated
| @@ -270,7 +270,9 @@ def _analyze_class(ctx: 'mypy.plugin.ClassDefContext', | |||
| # instance level assignments. | |||
| if attribute.name in ctx.cls.info.names: | |||
| node = ctx.cls.info.names[attribute.name].node | |||
| assert isinstance(node, Var) | |||
| if not isinstance(node, Var): | |||
| # This node may be not ready yet (i.e. a PlaceholderNode). | |||
There was a problem hiding this comment.
Should we instead check for PlaceholderNode? If there's something unexpected there, weird things might happen.
test-data/unit/check-attr.test
Outdated
| total = attr.ib(type=Bad) # E: Name 'Bad' is not defined | ||
| [builtins fixtures/bool.pyi] | ||
|
|
||
| [case testTypeInAttrBad2] |
There was a problem hiding this comment.
Maybe rename the test case? There seems nothing bad here, just a forward reference.
test-data/unit/check-attr.test
Outdated
| class Forward: ... | ||
| [builtins fixtures/bool.pyi] | ||
|
|
||
| [case testTypeInAttrBad3] |
There was a problem hiding this comment.
Similar to above, the test case name doesn't seem quite right.
|
Travis looks stuck. I am going to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7098