Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New analyzer: reverse order of modules within SCC #7163

Merged
merged 6 commits into from
Jul 8, 2019
Merged

New analyzer: reverse order of modules within SCC #7163

merged 6 commits into from
Jul 8, 2019

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Jul 5, 2019

This brings the new semantic analyzer closer to the old one.

TODO: Add tests for order of processing

@JukkaL JukkaL requested a review from ilevkivskyi July 5, 2019 17:33
ilevkivskyi
ilevkivskyi approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Also adding the [targets ...] to some of the tests would be great.

@JukkaL JukkaL merged commit 028f202 into master Jul 8, 2019
@JukkaL JukkaL mentioned this pull request Jul 8, 2019
Closed
@JelleZijlstra JelleZijlstra deleted the semanal-scc-order branch July 8, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JukkaL @ilevkivskyi