Bind self correctly when mapping class methods from supertype #7474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Sep 5, 2019
Collaborator
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
One question but looks good
mypy/checker.py
Outdated
| elif isinstance(sym.node, OverloadedFuncDef): | ||
| is_class_method = sym.node.is_class | ||
| else: | ||
| is_class_method = False |
Collaborator
There was a problem hiding this comment.
Should we check is_class for regular FuncDefs? (It can be implicit for certain functions, right?)
Member
Author
There was a problem hiding this comment.
Hm, you are right, it is better to be on the safe side.
ilevkivskyi
added a commit
that referenced
this pull request
Sep 10, 2019
Fix a regression caused by #7474 The original PR correctly added `is_classmethod=...` in `bind_self()` for supertype, but I didn't notice the same problem (flag not passed) was also present for _subtype_. The fix is trivial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2511