Correctly process properties provided in mixins #7713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Oct 15, 2019
mypy/checker.py
Outdated
| @@ -1886,6 +1886,10 @@ class C(B, A[int]): ... # this is unsafe because... | |||
| ok = is_subtype(first_sig, second_sig, ignore_pos_arg_names=True) | |||
| elif first_type and second_type: | |||
| ok = is_equivalent(first_type, second_type) | |||
| if not ok and name in base2.abstract_attributes: | |||
There was a problem hiding this comment.
Maybe I am missing something but I think this should be OK even if name is not abstract, so I would remove the right part of and.
There was a problem hiding this comment.
I think you're right; I had considered only the abstract case. Fixed.
| foo = "foo" | ||
| class C(Mixin, A): | ||
| pass | ||
| [out] |
There was a problem hiding this comment.
I would add couple more tests with a non-abstract property that check:
- the error is still shown if you switch the order of bases in
C. - the error is not shown if type in
Mixinis a strict subtype of type in property (it is safe since it is read-only)
There was a problem hiding this comment.
Added some more tests.
Xyene
changed the title
ilevkivskyi
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing the issue reported in #7631. I'm happy to address any issues that might be present in this first approach.
Fixes #7631