Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync typeshed #7819

Closed
wants to merge 2 commits into from
Closed

sync typeshed #7819

wants to merge 2 commits into from

Conversation

JelleZijlstra
Copy link
Member

Prepare for merging python/typeshed#3371 and the accompanying mypy PR.

@JelleZijlstra
Copy link
Member Author

A bunch of errors of the form __init__.pyi:116: error: Name 'DefaultEventLoopPolicy' already defined (possibly by an import) (diff) appeared.

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 30, 2019

The errors are from stdlib/3/asyncio/__init__.pyi. On Windows, DefaultEventLoopPolicy is multiply defined because of from asyncio.windows_events import * on line 91.

@JukkaL JukkaL mentioned this pull request Oct 30, 2019
@JelleZijlstra
Copy link
Member Author

Right, I'm working on a typeshed PR now to fix it.

JukkaL added a commit that referenced this pull request Oct 30, 2019
This syncs to an earlier commit than #7819 to avoid a problematic commit.
Prepare for merging python/typeshed#3371 and the accompanying mypy PR.
@jlaine
Copy link

jlaine commented Nov 13, 2019

The error is now:

test-data\samples\crawl.py:838: error: Incompatible types in assignment (expression has type "AbstractEventLoop", variable has type "ProactorEventLoop")

Any chance of getting this fixed so typeshed can be resynced?

@msullivan
Copy link
Collaborator

I merged #7948, syncing typeshed

@msullivan msullivan closed this Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants