Show closest candidates for misspellings : keyword argument case #7888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Nov 6, 2019
test-data/unit/check-kwargs.test
Outdated
| [case testKeywordMisspellingFloatInt] | ||
| def f(atter: float, btter: int) -> None: pass # N: "f" defined here | ||
| x: int = 5 | ||
| f(otter=x) # E: Unexpected keyword argument "otter" for "f"; did you mean "btter" or "atter"? |
There was a problem hiding this comment.
Could you please add a test or two involving *args to be sure they don't interfere with the logic?
There was a problem hiding this comment.
Good catch!
Added some tests.
And the *args did interfere with the logic. --> improved logic
Add tests for *args Fix bugs with *args Remove redundant type check
ilevkivskyi
reviewed
Nov 6, 2019
style improvements
ilevkivskyi
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following case outlined in #824
Unexpected keyword argument "otter" for "f"is now
Unexpected keyword argument "otter" for "f"; did you mean "other"?